Re: Proposal: new border setting in psql

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: "D'Arcy J(dot)M(dot) Cain" <darcy(at)druid(dot)net>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Proposal: new border setting in psql
Date: 2009-01-08 16:24:46
Message-ID: 200901081624.n08GOkN07630@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

D'Arcy J.M. Cain wrote:
> On Thu, 8 Jan 2009 12:30:52 -0300
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> wrote:
> > > It is a great feature for people actually using ReST. However, the
> > > feature is really just a logical extension to the existing border
> > > attribute.
> >
> > Frankly I don't understand your position. You seem to be saying that
> > you want the logical extension to the border feature, because it's very
> > easy to write, but you don't want to go to all the trouble of writing an
> > actual rst output format -- I guess it's a lot more code. You don't
> > care that your new border format is not actually rst, because you have
> > no need for rst.
>
> In fact I wrote it because I do want it for ReST. When I first
> proposed it that was my sell. I received pushback because it was for
> too specific a purpose so I stepped back and showed that it was simply
> a logical extension that happened to work as ReST input. Now it seems
> that unless it is 100% ReST and documented as such it will be rejected.
>
> I'm feeling the ground shift under me.

Can you find an email that shows this; I don't remember a shift.

> > Some people suggests that this is so close to rst that I should just use
> > it as if it were, and hand-edit the output for the rare cases where it
> > doesn't comply. I don't find this very compelling.
>
> The cases are so rare that I can't remember what they were if any.

Well, Tom pointed out a few, the most obvious being backslashing markup
characters:

http://docutils.sourceforge.net/docs/user/rst/quickref.html#escaping

and there is a heck of a lot of markup:

http://docutils.sourceforge.net/docs/user/rst/quickref.html#inline-markup

If you want another mode that doesn't do the backslashing, that is fine,
but the ReST-required backslashes are necessary for it to be accepted.

> > Apparently the bottom line is that if it's not actual rst, it will get
> > rejected.
>
> OK, it's ReST. If there is a corner case that breaks ReST I am willing
> to treat it as a bug and fix it.
>
> Perhaps ReST should be the next level. That way people who just want
> the extra lines can get what they want and people who need 100% ReST
> can use "border 4" instead. That's if there is any difference of
> course. We could document "border 4" as ReST with no change to my code
> patch until we find some case where "border 3" breaks ReST.

See above, there are lots of cases, and we aren't going to accept the
patch with partial ReST support and wait for people to complain --- it
is already clear the patch is not 100% ReST compliant.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Cédric Villemain 2009-01-08 16:34:57 Re: Proposal: new border setting in psql
Previous Message Stephen Frost 2009-01-08 16:22:39 Re: Open item: kerberos warning message