From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
Cc: | Sushant Sinha <sushant354(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org, Teodor Sigaev <teodor(at)sigaev(dot)ru> |
Subject: | Re: text search patch status update? |
Date: | 2009-01-08 01:50:20 |
Message-ID: | 200901080150.n081oKX20489@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Uh, where are we on this? I see the same output in CVS HEAD as Heikki,
and I assume he thought at least one of them was wrong. ;-)
---------------------------------------------------------------------------
Heikki Linnakangas wrote:
> Sushant Sinha wrote:
> > Patch #2. I think this is a straigt forward bug fix.
>
> Yes, I think you're right. In hlCover(), *q is 0 when the only match is
> the first item in the text, and we shouldn't bail out with "return
> false" in that case.
>
> But there seems to be something else going on here as well:
>
> postgres=# select ts_headline('1 2 3 4 5', '2'::tsquery, 'MinWords=2,
> MaxWords=3');
> ts_headline
> --------------
> <b>2</b> 3 4
> (1 row)
>
> postgres=# select ts_headline('aaa1 aaa2 aaa3 aaa4
> aaa5','aaa2'::tsquery, 'MinWords=2, MaxWords=3');
> ts_headline
> ------------------
> <b>aaa2</b> aaa3
> (1 row)
>
> In the first example, you get three words, and in the 2nd, just two. It
> must be because of the default ShortWord setting of 3. Also, if only the
> last word matches, and it's a "short word", you get the whole text:
>
> postgres=# select ts_headline('1 2 3 4 5','5'::tsquery, 'MinWords=2,
> MaxWords=3');
> ts_headline
> ------------------
> 1 2 3 4 <b>5</b>
> (1 row)
>
> --
> Heikki Linnakangas
> EnterpriseDB http://www.enterprisedb.com
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2009-01-08 02:13:58 | Re: New patch for Column-level privileges |
Previous Message | Bruce Momjian | 2009-01-08 01:42:46 | Re: Potential Join Performance Issue |