Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions

From: Nikolay Shaplov <dhyan(at)nataraj(dot)su>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: Georgios Kokolatos <gkokolatos(at)protonmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, Amit Langote <amitlangote09(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Subject: Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions
Date: 2021-07-22 08:30:51
Message-ID: 20087087.dtqIWialUB@x200m
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

В письме от среда, 14 июля 2021 г. 15:09:12 MSK пользователь vignesh C
> The patch does not apply on Head anymore, could you rebase and post a
> patch. I'm changing the status to "Waiting for Author".

Thank you for notification.

I've tried to rebase it and found out that some options have been added to
partitioned table.
Handling this needs careful approach, and I will fix it two weeks later, when I
am back from vacations.

Meanwhile I would strongly suggest to change

{"vacuum_index_cleanup", RELOPT_TYPE_BOOL,


{"vacuum_index_cleanup", RELOPT_TYPE_ENUM,

in src/backend/access/common/reloptions.c

This change should be done in 3499df0d
But current implementation of reloptions is very error prone , and it is very
easy to miss this part.

Nikolay Shaplov
dhyan(at)nataraj(dot)su (e-mail, jabber) (matrix)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peifeng Qiu 2021-07-22 08:39:53 Re: Kerberos delegation support in libpq and postgres_fdw
Previous Message Peter Smith 2021-07-22 08:11:08 Re: logical replication empty transactions