| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, dmitry(at)koterov(dot)ru, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: PostgreSQL 8.3.4 reproducible crash |
| Date: | 2008-12-12 13:40:12 |
| Message-ID: | 20081212134012.GD3806@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> 1. Ensure that a snapshot is set before doing parse analysis of any
> non-utility command. (We *must* not set a snap before LOCK or a
> transaction control command, and it seems best to not do it for any
> utility command.) One issue here is that this would change the behavior
> for mixed utility and non-utility commands in a single query string;
> though I'm not sure how much that matters.
I think this is the easiest way out, and the most robust -- we won't be
bitten by some other operation that the parser may think of doing.
(Note that utility commands have their snapshot set in
PortalRunUtility). Also, perhaps this would let us clean the mess in
pg_plan_queries.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David E. Wheeler | 2008-12-12 13:41:11 | Re: WIP: default values for function parameters |
| Previous Message | Tom Lane | 2008-12-12 13:39:14 | Re: WIP: default values for function parameters |