Re: pgsql: Reduce risk of accidentally running temp-install regression tests

On Fri, Nov 28, 2008 at 06:54:15PM -0500, Tom Lane wrote:
> temp port. But it looks like the temp port number is actually wired
> into some of the ecpg tests' expected results, and so getting rid of it
> is not as easy as one could wish.

Should only one test, that some installations do not even run, but still, yes,
it makes things more difficult.

> Michael, could you look at removing that dependency so we can let
> pg_regress.c select the port number as it wishes? If it's not practical
> to suppress the port number in the regression test output, maybe things
> could be changed so that pg_regress.c itself substitutes in the port
> number it's chosen.

Suppressing the output defies the purpose for this one test, namely to check
different ways to connect. If pg_regress is able do the job of two sed calls in
can easily substitute the port number itself. I'm not sure if this is worth the
hassle, or whether we just remove these parts of the regression test.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes(at)jabber(dot)org
Go VfL Borussia! Go SF 49ers! Use Debian GNU/Linux! Use PostgreSQL!