Re: Erroring out on parser conflicts

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Erroring out on parser conflicts
Date: 2008-11-25 19:15:44
Message-ID: 200811252115.45344.peter_e@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tuesday 25 November 2008 15:09:37 Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > While hacking on parser/gram.y just now I noticed in passing that the
> > automatically generated ecpg parser had 402 shift/reduce conflicts.
> > (Don't panic, the parser in CVS is fine.) If you don't pay very close
> > attention, it is easy to miss this. Considering also that we frequently
> > have to educate contributors that parser conflicts are not acceptable,
> > should we try to error out if we see conflicts?
>
> Would "%expect 0" produce the same result in a less klugy way?

Great, that works. I'll see about adding this to our parser files.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2008-11-25 19:27:09 Re: Exporting PGINTERVALSTYLE prevents access to older server versions
Previous Message Merlin Moncure 2008-11-25 19:14:10 Re: [bugfix] DISCARD ALL does not release advisory locks