| From: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | "Hitoshi Harada" <umi(dot)tanuki(at)gmail(dot)com> |
| Cc: | "PostgreSQL Hackers" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Window Functions: v07 APIs and buffering strateties |
| Date: | 2008-10-28 07:58:10 |
| Message-ID: | 20081028162348.DC5D.52131E4D@oss.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"Hitoshi Harada" <umi(dot)tanuki(at)gmail(dot)com> wrote:
> And I fixed this problem, confirming with/without debug/cassert/gcc
> -O and push it to git. If you want delta patch, please see
> http://git.postgresql.org/?p=~davidfetter/window_functions/.git;a=commitdiff;h=fbf19bfd0c8d2ac083b775f4cc724ec66e74fa8f
Now it passed all regression tests!
There is still one trivial warning:
parse_func.c: In function `ParseFuncOrColumn':
parse_func.c:77: warning: 'retval' might be used uninitialized in this function
It looks completely safe, but I suggest to initialize
the variable only to keep compiler quiet.
[src/backend/parser/parse_func.c] ParseFuncOrColumn()
else
+ {
elog(ERROR, "unknown function status");
+ retval = NULL; /* keep compiler quiet */
+ }
Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hitoshi Harada | 2008-10-28 08:09:50 | Re: Window Functions: v07 APIs and buffering strateties |
| Previous Message | Koichi Suzuki | 2008-10-28 07:33:03 | Proposal of PITR performance improvement for 8.4. |