Re: pg_start_backup() takes too long

From: Joshua Drake <jd(at)commandprompt(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Simon Riggs <simon(at)2ndQuadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ivan Zolotukhin <ivan(dot)zolotukhin(at)gmail(dot)com>, PostgreSQL General <pgsql-general(at)postgresql(dot)org>
Subject: Re: pg_start_backup() takes too long
Date: 2008-09-29 23:26:28
Message-ID: 20080929162628.1a05852b@jd-laptop
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-general

On Mon, 29 Sep 2008 19:06:46 -0400 (EDT)
Bruce Momjian <bruce(at)momjian(dot)us> wrote:

> I agree with Tom; either we make the pg_start_backup() checkpoint
> immediate or leave the behavior unchanged.
>
> Personally I think immediate makes more sense because issuing
> pg_start_backup() seems like it should behave like a manual CHECKPOINT
> command.
>

I am not actually that concerned that it takes a long time now that I
know why. I am more concerned that it isn't obvious why it takes so
long. Something like this would be more than sufficient:

elog(NOTICE, "pg_start_backup called, issuing CHECKPOINT");
RequestCheckpoint(CHECKPOINT_FORCE | CHECKPOINT_WAIT);

Sincerely,

Joshua D. Drake

--
The PostgreSQL Company since 1997: http://www.commandprompt.com/
PostgreSQL Community Conference: http://www.postgresqlconference.org/
United States PostgreSQL Association: http://www.postgresql.us/

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Tom Lane 2008-09-29 23:26:43 Re: Can't cast from char to integer...
Previous Message Bruce Momjian 2008-09-29 23:06:46 Re: pg_start_backup() takes too long