| From: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] 0x1A in control file on Windows |
| Date: | 2008-09-18 06:57:55 |
| Message-ID: | 20080918154713.80E5.52131E4D@oss.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> writes:
> > We probably need to add PG_BINARY when we open control files
> > because 0x1A is an end-of-file marker on Windows.
>
> Well, why is that a bug? If the platform is so silly as to define text
> files that way, who are we to argue?
Google says it is for for backward compatibility with CP/M
http://en.wikipedia.org/wiki/End-of-file
and adding O_BINARY is the answer.
http://codenewbie.com/forum/standard-c-c/1208-binary-i-o-file-reading-0x1a-trouble.html
Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andreas Peer | 2008-09-18 07:41:57 | Re: BUG #4421: convert_to() should be immutable |
| Previous Message | Tom Lane | 2008-09-18 04:48:34 | Re: [HACKERS] 0x1A in control file on Windows |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2008-09-18 07:01:36 | Re: optimizing CleanupTempFiles |
| Previous Message | Heikki Linnakangas | 2008-09-18 06:23:08 | Re: optimizing CleanupTempFiles |