From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, List pgsql-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] Infrastructure changes for recovery |
Date: | 2008-09-12 18:14:21 |
Message-ID: | 20080912181421.GI8854@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Simon Riggs wrote:
> --- 5716,5725 ----
> CheckpointStats.ckpt_sync_end_t,
> &sync_secs, &sync_usecs);
>
> ! elog(LOG, "%s complete: wrote %d buffers (%.1f%%); "
> "%d transaction log file(s) added, %d removed, %d recycled; "
> "write=%ld.%03d s, sync=%ld.%03d s, total=%ld.%03d s",
> + (checkpoint ? " checkpoint" : "restartpoint"),
> CheckpointStats.ckpt_bufs_written,
> (double) CheckpointStats.ckpt_bufs_written * 100 / NBuffers,
> CheckpointStats.ckpt_segs_added,
Very minor nit: this really needs a rework. It is relatively OK in the
previous code, but it was already stuffing too much in a single message.
Maybe
ereport(LOG,
(errmsg(checkpoint ? "checkpoint complete" : "restartpoint complete"),
errdetail("Wrote %d buffers (%.1f%%); "
"%d transaction log file(s) added, %d removed, %d recycled; "
"write=%ld.%03d s, sync=%ld.%03d s, total=%ld.%03d s.",
...
)))
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
From | Date | Subject | |
---|---|---|---|
Next Message | David E. Wheeler | 2008-09-12 18:21:53 | Re: [Review] Tests citext casts by David Wheeler. |
Previous Message | David E. Wheeler | 2008-09-12 18:14:00 | Re: [Review] Tests citext casts by David Wheeler. |
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2008-09-12 18:56:06 | Re: [HACKERS] Infrastructure changes for recovery |
Previous Message | Alex Hunsaker | 2008-09-12 16:32:57 | Re: hash index improving v3 |