| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> | 
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> | 
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, List pgsql-patches <pgsql-patches(at)postgresql(dot)org> | 
| Subject: | Re: [HACKERS] Infrastructure changes for recovery | 
| Date: | 2008-09-12 18:56:06 | 
| Message-ID: | 1221245766.3913.1130.camel@ebony.2ndQuadrant | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches | 
On Fri, 2008-09-12 at 14:14 -0400, Alvaro Herrera wrote:
> Simon Riggs wrote:
> 
> > --- 5716,5725 ----
> >   						CheckpointStats.ckpt_sync_end_t,
> >   						&sync_secs, &sync_usecs);
> >   
> > ! 	elog(LOG, "%s complete: wrote %d buffers (%.1f%%); "
> >   		 "%d transaction log file(s) added, %d removed, %d recycled; "
> >   		 "write=%ld.%03d s, sync=%ld.%03d s, total=%ld.%03d s",
> > + 		 (checkpoint ? "  checkpoint" : "restartpoint"),
> >   		 CheckpointStats.ckpt_bufs_written,
> >   		 (double) CheckpointStats.ckpt_bufs_written * 100 / NBuffers,
> >   		 CheckpointStats.ckpt_segs_added,
> 
> Very minor nit: this really needs a rework.  
All I changed was the word "restartpoint"... its otherwise identical to
existing message. I'd rather not change that.
-- 
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ron Mayer | 2008-09-12 19:09:35 | Re: Proposed patch: make SQL interval-literal syntax work per spec | 
| Previous Message | David E. Wheeler | 2008-09-12 18:49:04 | Re: [Review] Tests citext casts by David Wheeler. | 
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2008-09-12 19:31:44 | Re: [HACKERS] Infrastructure changes for recovery | 
| Previous Message | Alvaro Herrera | 2008-09-12 18:14:21 | Re: [HACKERS] Infrastructure changes for recovery |