| From: | "D'Arcy J(dot)M(dot) Cain" <darcy(at)druid(dot)net> |
|---|---|
| To: | "Brendan Jurd" <direvus(at)gmail(dot)com> |
| Cc: | "Magnus Hagander" <magnus(at)hagander(dot)net>, "Bruce Momjian" <bruce(at)momjian(dot)us>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Josh Berkus" <josh(at)agliodbs(dot)com>, "Gregory Stark" <stark(at)enterprisedb(dot)com>, "PG Hackers" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Parsing of pg_hba.conf and authentication inconsistencies |
| Date: | 2008-09-12 14:33:43 |
| Message-ID: | 20080912103343.565f0370.darcy@druid.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 12 Sep 2008 06:53:55 +1000
"Brendan Jurd" <direvus(at)gmail(dot)com> wrote:
> Josh has assigned your patch to me for an initial review.
And me.
> First up I'd like to say that this is a really nice upgrade.
> Shielding a running server from reloading a bogus conf file makes a
> whole lot of sense.
Yes.
> The patch applied cleanly to HEAD, compiled fine on amd64 gentoo and
I had a small problem compiling. I'm not sure why it would be
different for me. I run NetBSD -current. Here is the error:
../../../src/include/libpq/hba.h:51: error: field 'addr' has incomplete
type
I was able to fix this by adding the following line to hba.h:
#include "libpq/pqcomm.h" /* needed for struct sockaddr_storage */
--
D'Arcy J.M. Cain <darcy(at)druid(dot)net> | Democracy is three wolves
http://www.druid.net/darcy/ | and a sheep voting on
+1 416 425 1212 (DoD#0082) (eNTP) | what's for dinner.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2008-09-12 14:46:23 | Re: pg_regress inputdir |
| Previous Message | Kenneth Marshall | 2008-09-12 14:29:21 | Re: hash index improving v3 |