| From: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | "Hitoshi Harada" <umi(dot)tanuki(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: NDirectFileRead and Write |
| Date: | 2008-09-08 09:23:17 |
| Message-ID: | 20080908180748.983F.52131E4D@oss.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"Hitoshi Harada" <umi(dot)tanuki(at)gmail(dot)com> wrote:
> so I guess all of these variables should be defined together but
> actually you put the two in buffile.h while the others in
> buf_internals.h. Is there clear reason for that?
That's because buffile.c includes buffile.h, but not buf_internals.h .
NDirectFileRead/Writes are counters for BufFile in the patch
and don't depend on bufmgr.
It might be cleaner if we had something like storage/bufstats.h
and declared all counter variables in it, but it seems to be an overkill.
Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | ITAGAKI Takahiro | 2008-09-08 10:19:54 | Re: Synchronous Log Shipping Replication |
| Previous Message | Heikki Linnakangas | 2008-09-08 09:13:27 | Re: Prototype: In-place upgrade v02 |