Re: [Review] pgbench duration option

From: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: "Brendan Jurd" <direvus(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Cc: Ragnar <gnari(at)hive(dot)is>
Subject: Re: [Review] pgbench duration option
Date: 2008-09-08 08:59:41
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Here is a revised version of the pgbench duration patch.
I merged some comments from Brendan and gnari.

"Brendan Jurd" <direvus(at)gmail(dot)com> wrote:

> >> Wouldn't this be better written as:
> >> if ((duration > 0 && timer_exceeded) || st->cnt >= nxacts)
> >
> > sorry, but these do not lok as the same thing to me.
> > gnari

I used this condition expression here:
if ((st->cnt >= nxacts && duration <= 0) || timer_exceeded)

ITAGAKI Takahiro
NTT Open Source Software Center

Attachment Content-Type Size
pgbench-duration_v3.patch application/octet-stream 8.6 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2008-09-08 09:10:36 Re: Prototype: In-place upgrade v02
Previous Message Zdenek Kotala 2008-09-08 08:58:09 Re: hash index improving v3