Re: [PATCH] Cleanup of GUC units code

Gregory Stark wrote:
> "Greg Sabino Mullane" <greg(at)turnstep(dot)com> writes:
>
> > Tom Lane wrote:
> >> My vote is to reject the patch and work on a config checker.
> >
> > +1
> >
> >> postgres=# set work_mem = '1g';
> >> ERROR: invalid value for parameter "work_mem": "1g"
> >
> > Perhaps this would be a great place for a HINT listing all
> > valid inputs, if not there already?
>
> It is, I paraphrased it on my original message as:
>
> HINT: It's perfectly clear what you want but I'm going to refuse to do
> it until you type it exactly as I say: "GB"

It's good as a joke, but what if the user says '1024b'? Does it mean
1024 blocks or one kilobyte? If blocks, what size are we talking, the
usual 512 bytes, or our BLCKSZ?

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support