Re: Auto-explain patch

From: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: Dean Rasheed <dean_rasheed(at)hotmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndquadrant(dot)com>, <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Auto-explain patch
Date: 2008-08-26 10:24:10
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


I'm very interested in the auto-explain feature.
Are there any plans to re-add it in the next commit-fest?

Dean Rasheed <dean_rasheed(at)hotmail(dot)com> wrote:

> > Please do not export ExplainState --- that's an internal matter for
> > explain.c. Export some wrapper function with a cleaner API than
> > explain_outNode, instead.
> OK, that's much neater.

How about the attached patch?
I exported initialization of ExplainState and explain_outNode call
to a new function ExplainOneResult. It receives executor nodes and
returns the tree as a text.

I think it'd be better to implement the auto-explain feature
not as a core feature but as an extension, because various users
have various desires about the feature. We could write a small extension
moudle using hooks and the ExplainOneResult function. If we includes
the extension as a contrib module, users can mofify it and install
customized version of auto-explain.

ITAGAKI Takahiro
NTT Open Source Software Center

Attachment Content-Type Size
export_explain.patch application/octet-stream 2.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Jan Urbański 2008-08-26 10:45:10 Re: gsoc, oprrest function for text search take 2
Previous Message Greg Smith 2008-08-26 07:15:29 Re: Split up the wiki TODO page?