Re: Confusing message in log file

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Confusing message in log file
Date: 2008-08-22 00:04:45
Message-ID: 200808220004.m7M04kR09952@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Wording adjusted and applied with attached patch.

---------------------------------------------------------------------------

Gurjeet Singh wrote:
> On Mon, Jun 30, 2008 at 7:33 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> > Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > > In any case, this seems a case of stuffing too much in the primary
> > > message.
> >
> > Yeah, good point.
> >
> > > I think it should be something like
> > > errmsg("parameter \"shared_buffer\" change in configuration file
> > ignored"),
> > > errdetail("This parameter cannot be changed after server start.")
> >
> > Seems a bit awkwardly phrased. I propose
> >
> > errmsg("attempted change to parameter \"shared_buffer\" ignored"),
> > errdetail("This parameter cannot be changed after server start.")
> >
> > (or possibly "of" would read better than "to")
> >
> >
> 'of' sounds better than 'to'.
>
> Best regards,
> --
> gurjeet[(dot)singh](at)EnterpriseDB(dot)com
> singh(dot)gurjeet(at){ gmail | hotmail | indiatimes | yahoo }.com
>
> EnterpriseDB http://www.enterprisedb.com
>
> Mail sent from my BlackLaptop device

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachment Content-Type Size
/rtmp/diff text/x-diff 2.4 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2008-08-22 00:10:42 Re: [HACKERS] [FINALLY] the TODO list has migrated to Wiki
Previous Message Alvaro Herrera 2008-08-22 00:03:56 Re: [HACKERS] [FINALLY] the TODO list has migrated to Wiki