Re: Uncopied parameters on CREATE TABLE LIKE

From: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Uncopied parameters on CREATE TABLE LIKE
Date: 2008-08-13 00:38:56
Message-ID: 20080813092919.87A5.52131E4D@oss.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:

> On Tue, 2008-08-12 at 13:34 -0400, Bruce Momjian wrote:
> > Is there a TODO here?
>
> Yes, three:

> * create plugin API to allow extensible reloptions

Yes, and some index access methods (gist and gin) should have
abilities to handle reloptions in user defined functions, too.

> * allow reloptions to be copied when using INCLUDING DEFAULTS
> (if I got that right..)

The part "INCLUDING DEFAULTS" is not correct. Reloptions are attribute
of table, not of columns. So they should not be copied on LIKE and INHERITS.
Of course, we'd better to have convenient way to copy reltoptions from
another table, but concrete syntax was not suggested in the discussion.
(and I don't have.)

> * allow new option to copy comments INCLUDING COMMENTS

Sure.

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2008-08-13 01:12:15 Re: Plugin system like Firefox
Previous Message Tom Raney 2008-08-12 23:53:50 Planner question