Re: [PATCH] "\ef <function>" in psql

From: Abhijit Menon-Sen <ams(at)oryx(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] "\ef <function>" in psql
Date: 2008-07-29 10:12:27
Message-ID: 20080729101227.GA11196@toroid.org
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

At 2008-07-23 10:50:03 -0400, tgl(at)sss(dot)pgh(dot)pa(dot)us wrote:
>
> > What would the function return? "CREATE OR REPLACE FUNCTION ..."?
>
> I think I'd go with CREATE FUNCTION for simplicity.

OK, I have a mostly working pg_get_functiondef now, and some questions
about the remaining pieces:

1. Why is "prorows" a float4? Should I print it that way, i.e. "%f"?

2. Can I print the contents of "proconfig" as just "SET %s"? It seems
to work for the variables I've tried (e.g. "DateStyle=iso"), but I
wonder if they'll always be quoted correctly (i.e., if the "split
on '='" thing pg_dump does is necessary for an 8.4 function).

3. Is there a function I can use from ruleutils.c to do dollar quoting
of prosrc/probin? If not, and I have to write one, where should it
live?

4. What exactly is probin? Do I need to worry about it at all?

Thanks.

-- ams

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Asko Oja 2008-07-29 10:52:20 Re: [PATCH] "\ef <function>" in psql
Previous Message Peter Eisentraut 2008-07-29 08:41:37 Re: [WIP] patch - Collation at database level