Re: [PATCHES] WITH RECUSIVE patches 0717

On Thu, Jul 17, 2008 at 06:40:25PM +0900, Tatsuo Ishii wrote:
> Hi,
>
> Here is the lastest WITH RECURSIVE patches against CVS HEAD created by
> Yoshiyuki Asaba and minor corrections by Tatsuo Ishii.

I tried this patch vs. CVS HEAD used my usual configure option with
only --with-prefix set, then tried to make, and got:

make[3]: *** No rule to make target `parse_cte.o', needed by `objfiles.txt'. Stop.
make[3]: Leaving directory `/home/shackle/pgsql/src/backend/parser'
make[2]: *** [parser-recursive] Error 2
make[2]: Leaving directory `/home/shackle/pgsql/src/backend'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/shackle/pgsql/src'
make: *** [all] Error 2

Is there something missing?

> (David Fetter's psql help patches are not included. It seems his git
> repository has gone).

I apologize for that. I rearranged it last night because the name was
not scalable, but delayed sending this out until today. It can now be
found at

<http://git.postgresql.org/?p=~davidfetter/with_recursive/.git;a=summary>

To pull from the new location, in your .git/config, change URL from something
like the following:

url = git://davidfetter(at)git(dot)postgresql(dot)org/git/~davidfetter/postgresql/.git

to

url = git://davidfetter(at)git(dot)postgresql(dot)org/git/~davidfetter/with_recursive/.git

> This version implements:
>
> - detect certain queries those are not valid acroding to the standard

Great :)

> I also include erroneous query examples created by Yoshiyuki (probably
> will become part of regression tests).
>
> Remaining problmes are:
>
> 1) sort query names acording to the dependency

This can be done at query time already using arrays per Asaba-san's
suggestion. I'll add some examples to the documentation.

> 2) planner always estimate 0 cost for recursion plans
> 3) add regression tests
>
> For 1), I have proposed we limit query names to 1, in another word do
> not allow mutually recursive queries. For 2) there's no good idea to
> solve it, so I suggest leave it as it is now.
>
> For 3) I will generate regression tests as soon as possible.
>
> So the patches seem to be almost ready to commit IMO.

Wonderful!

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate