From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>, PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Confusing message in log file |
Date: | 2008-06-30 23:02:04 |
Message-ID: | 20080630230204.GD18252@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Bruce Momjian escribió:
> Gurjeet Singh wrote:
> > May 14 21:38:40 sfphotodb001 postgres[29658]: [19-1] 2008-05-14 21:38:40
> > PDTLOG: received SIGHUP, reloading configuration files
> > May 14 21:38:40 sfphotodb001 postgres[29658]: [20-1] 2008-05-14 21:38:40
> > PDTLOG: parameter "shared_buffers" cannot be changed after server start;
> > configuration file change ignored
> > What's confusing about this is that the second message says
> > 'configuration file change ignored', so I expect the changed (newly enabled)
> > archive_command to not take effect. But in fact, it does take effect.
> >
> > The message probably should be rephrased to say that this setting
> > (shared_buffers) will not be changed.
>
> Actually, no one else has been confused by this wording before, and I
> can't think of better wording that doesn't sound redundant.
Perhaps this is because not enough people have seen it. I agree that
the message should specify that only this setting has been ignored.
In any case, this seems a case of stuffing too much in the primary
message. I think it should be something like
errmsg("parameter \"shared_buffer\" change in configuration file ignored"),
errdetail("This parameter cannot be changed after server start.")
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2008-06-30 23:23:06 | Planned obsolescence in identify_system_timezone() |
Previous Message | Bruce Momjian | 2008-06-30 22:54:46 | Re: Confusing message in log file |