Re: Fix pg_ctl restart bug

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Fix pg_ctl restart bug
Date: 2008-06-27 01:54:46
Message-ID: 200806270154.m5R1skj15358@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Alvaro Herrera wrote:
> >> I've always assumed that I'm supposed to backpatch the bugs I fix in
> >> HEAD, however far is reasonable.
>
> > I thought we only backatched major bugs to prevent possible instability
> > when fixing minor bugs.
>
> Actually, Bruce, this *is* a minor bug; if it were major we'd have heard
> about it from the field.
>
> My take on it is that "pg_ctl restart" must be practically unused.
> Given that we now know it's completely broken, the only way that
> patching it could make the situation worse would be if the patch
> affected some other code path that people actually do use. As
> long as you're sure it doesn't do that, I see no downside to an
> attempted fix, even if it fails.

OK, done; backpatched from 8.0.X to 8.3.X.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message raneyt 2008-06-27 04:48:39 Explain XML patch
Previous Message Bruce Momjian 2008-06-26 22:51:46 Removal of the patches email list