Re: Kludge in pg_standby.c

Alvaro Herrera wrote:
> > Gregory Stark wrote:
> > >
> > > There's a suspicious ifdef in pg_standby for WIN32 which smells like a kludge
> > > added to work around a Windows problem which makes it work but at great
> > > expense:
> > >
> > > #ifdef WIN32
> > > /*
> > > * Windows reports that the file has the right number of bytes
> > > * even though the file is still being copied and cannot be
> > > * opened by pg_standby yet. So we wait for sleeptime secs
> > > * before attempting to restore. If that is not enough, we
> > > * will rely on the retry/holdoff mechanism.
> > > */
> > > pg_usleep(sleeptime * 1000000L);
> > > #endif
>
> FWIW, it seems that this may be fixed with Magnus' patch to change
> stat() on Win32. Is there anyone with a working warm standby PITR setup
> on Win32 that could test it?

Is this fixed and this block of code can be removed?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +