Re: Patch to change psql default banner v6

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > With major version mismatches it looks like this:
>
> > $ psql test
> > psql (8.4devel)
> > SSL connection (cipher: 2343, bits: 512)
> > WARNING: Console code page (323) differs from Windows code page (2323)
> > 8-bit characters might not work correctly. See psql reference
> > page "Notes for Windows users" for details.
> > WARNING: psql version 8.4.0, server version 8.3.1.
> > Some psql features might not work.
> > Type "help" for help.
>
> > By indenting those messages the 'help' message still stands out.
>
> My advice: don't do that, it just looks weird. Both of these look
> fine to me:
>
> $ psql test
> psql (8.4devel)
> SSL connection (cipher: 2343, bits: 512)
> Type "help" for help.
>
> $ psql test
> psql (8.4devel)
> SSL connection (cipher: 2343, bits: 512)
> WARNING: Console code page (323) differs from Windows code page (2323)
> 8-bit characters might not work correctly. See psql reference
> page "Notes for Windows users" for details.
> WARNING: psql version 8.4.0, server version 8.3.1.
> Some psql features might not work.
> Type "help" for help.
>
> Also, maybe it's just me, but I think you have put the order of these
> optional things exactly backwards. I'd do
>
> $ psql test
> psql (8.4devel)
> WARNING: psql version 8.4.0, server version 8.3.1.
> Some psql features might not work.
> WARNING: Console code page (323) differs from Windows code page (2323)
> 8-bit characters might not work correctly. See psql reference
> page "Notes for Windows users" for details.
> SSL connection (cipher: 2343, bits: 512)
> Type "help" for help.
>
> Why? Well, it's just more nearly the way it used to be.

OK, here is the mega-print:

$ psql test
psql (8.4devel, server 8.4devel)
WARNING: psql version 8.4, server version 8.4.
Some psql features might not work.
WARNING: Console code page (44) differs from Windows code page (55)
8-bit characters might not work correctly. See psql reference
page "Notes for Windows users" for details.
SSL connection (cipher: 55, bits: 512)
Type "help" for help.

test=>

Patch at ftp://momjian.us/pub/postgresql/mypatches/help.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +