| From: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: What to do with inline warnings? |
| Date: | 2008-05-14 17:31:33 |
| Message-ID: | 20080514173133.GB6456@svana.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 14, 2008 at 12:45:49PM -0400, Tom Lane wrote:
> > tqual.c: In function âHeapTupleSatisfiesVacuumâ:
> > tqual.c:88: error: inlining failed in call to âSetHintBitsâ: call is unlikely and code size would grow
> > tqual.c:1057: error: called from here
> > tqual.c:88: error: inlining failed in call to âSetHintBitsâ: call is unlikely and code size would grow
> > tqual.c:1061: error: called from here
>
> Hmm, it's a bit disturbing that the compiler is taking it upon itself to
> decide that these calls are "unlikely".
Perhaps would should give it some idea about how likely they'd be,
because clearly it has no idea now.
Have a nice day,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> Please line up in a tree and maintain the heap invariant while
> boarding. Thank you for flying nlogn airlines.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2008-05-14 17:36:43 | missing $PostgreSQL:$ |
| Previous Message | Tom Lane | 2008-05-14 17:10:24 | Re: Re: [COMMITTERS] pgsql: Improve logic for finding object files on OBJS lines in contrib |