Re: Snapshot management, final

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Pg Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Snapshot management, final
Date: 2008-05-12 20:07:35
Message-ID: 20080512200735.GC19344@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:

Patch committed, with most of these fixed. On this item:

> AtSubCommit_Snapshot can leave us with multiple RegdSnapshotElt's for
> the same snap and s_level, which seems a bit bogus.

I agree it is bogus. I punted though, and left the code as-is, with a
comment stating the problem. We can revisit this problem later if it's
ever an issue.

Many thanks for the extensive help.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2008-05-12 20:57:01 odd output in restore mode
Previous Message Tom Lane 2008-05-12 14:52:37 Re: [0/4] Proposal of SE-PostgreSQL patches