| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: bloated heapam.h |
| Date: | 2008-05-12 16:10:22 |
| Message-ID: | 20080512161022.GK5655@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Oops :-( I just noticed that I removed bufmgr.h from bufpage.h, which
> > is a change you had objected to previously :-(
> > http://archives.postgresql.org/pgsql-patches/2008-04/msg00149.php
>
> Hmm. I did notice that the patch seemed to need to add bufmgr.h
> inclusions to an awful lot of files, but I'd forgotten the argument
> about the bufpage.h macros needing it. Do you want to undo that
> aspect of it?
Done -- I put back bufmgr.h into bufpage.h. Surely there is a better
structure for this, perhaps involving more header files, but I don't
have time for that ATM.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2008-05-12 16:13:50 | Re: bloated heapam.h |
| Previous Message | Magnus Hagander | 2008-05-12 15:10:28 | Re: [COMMITTERS] pgsql: Convert wal_sync_method to guc enum. |