| From: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
|---|---|
| To: | Euler Taveira de Oliveira <euler(at)timbira(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, meskes(at)postgresql(dot)org |
| Subject: | Re: another ecpg crash |
| Date: | 2008-05-11 09:12:52 |
| Message-ID: | 20080511091252.GA14240@svana.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, May 11, 2008 at 02:19:05AM -0300, Euler Taveira de Oliveira wrote:
> Alvaro Herrera wrote:
>
> >Huh, isn't the test backwards?
> >
> In which way? I use a simple one but whatever test that uses 'exec sql
> include foo' and foo.h doesn't exist, it will crash.
I think he means specifically this line in the diff:
> ! /* there are some cases (i.e. file not found)
> ! * that the input is not available */
> ! if (!yyin)
> ! fclose(yyin);
This will close the file *only* if yyin is NULL, which probably isn't
what is meant.
Have a nice day,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> Please line up in a tree and maintain the heap invariant while
> boarding. Thank you for flying nlogn airlines.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tino Wildenhain | 2008-05-11 09:13:05 | Re: Setting a pre-existing index as a primary key |
| Previous Message | Nikhils | 2008-05-11 07:57:49 | Re: [badalex@gmail.com: Re: [BUGS] Problem identifying constraints which should not be inherited] |