Re: [GENERAL] pgbench not setting scale size correctly?

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Greg Smith <gsmith(at)gregsmith(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [GENERAL] pgbench not setting scale size correctly?
Date: 2008-05-07 21:38:50
Message-ID: 200805072138.m47LcoL17254@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-patches

Tom Lane wrote:
> Greg Smith <gsmith(at)gregsmith(dot)com> writes:
> > On Fri, 14 Mar 2008, Tom Lane wrote:
> >> Yeah, -s is only meaningful when given with -i. Maybe someday we ought
> >> to fix pgbench to complain if you try to set it at other times.
>
> > You have to pass -s in to the actual run if you're specifying your own
> > custom script(s) using -f and you want the :scale variable to be defined.
>
> Right, I knew that at one time ;-)
>
> > The way the option parsing code is done would make complaining in the case
> > where your parameter is ignored a bit of a contortion. The part that
> > detects based on the database is after all the other parsing because the
> > connection has to be brought up first.
>
> Yeah. But couldn't we have that part issue a warning if -s had been set
> on the command line?

Patch attached that issues a warning.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachment Content-Type Size
/pgpatches/pgbench text/x-diff 576 bytes

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Tom Lane 2008-05-07 21:41:01 Re: Backup/Restore of single table in multi TB database
Previous Message Tom Lane 2008-05-07 21:38:12 Re: pg_dumpall: pg_conversion table not saved

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2008-05-07 21:43:52 Re: [HACKERS] bug in numeric_power() function
Previous Message Magnus Hagander 2008-05-07 21:26:37 Re: Posting to hackers and patches lists