Re: pgsql: Make the pg_stat_activity view call a SRF

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Make the pg_stat_activity view call a SRF
Date: 2008-05-07 17:37:51
Message-ID: 20080507193751.2ecb50bf@mha-laptop.hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Tom Lane wrote:
> mha(at)postgresql(dot)org (Magnus Hagander) writes:
> > Make the pg_stat_activity view call a SRF (pg_stat_get_activity())
> > instead of calling a bunch of individual functions.
>
> > This function can also be called directly, taking a PID as an
> > argument, to return only the data for a single PID.
>
> Hmm, if you really intend the function to be used directly, then
> having to provide the output column list for it is a pretty big
> usability hit. Why not declare it with OUT parameters, instead?

That does sound like a very good idea... I did notice that as being a
problem, but didn't know how to fix it without thinking more :-)
How do I do that in pg_proc.h? Is there some other function that does
this that I can peek at for inspiration?

//Magnus

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message User Achernow 2008-05-07 17:59:36 libpqtypes - libpqtypes: makefile changes
Previous Message User Achernow 2008-05-07 17:14:16 libpqtypes - libpqtypes: enhanced html output from groff2html, fixed

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2008-05-07 17:46:11 Re: [NOVICE] encoding problems
Previous Message Alvaro Herrera 2008-05-07 17:37:02 Re: [NOVICE] encoding problems