Re: Patch to add a feature to pg_standby

From: David Fetter <david(at)fetter(dot)org>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, chris(dot)johnson(at)desknetinc(dot)com, pgsql-patches(at)postgresql(dot)org
Subject: Re: Patch to add a feature to pg_standby
Date: 2008-04-30 15:29:55
Message-ID: 20080430152955.GA31559@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Wed, Apr 30, 2008 at 03:43:54PM +0100, Simon Riggs wrote:
> On Wed, 2008-04-30 at 07:31 -0700, David Fetter wrote:
> > On Wed, Apr 30, 2008 at 12:49:44PM +0100, Simon Riggs wrote:
> > > On Wed, 2008-04-30 at 11:29 +0100, Heikki Linnakangas wrote:
> > > > This could be implemented by a "pass-through" restore_command,
> > > > that calls pg_standby, and does the custom action when
> > > > pg_standby returns successfully.
> > >
> > > Yes, that's the preferred route for most cases.
> > >
> > > pg_standby was designed to be customisable, so if it works for
> > > Chris, thats OK.
> > >
> > > After some mulling on this, I'm not sure we need to include this
> > > in pg_standby however. If we did we'd end up having before/after
> > > commands and retry options etc.
> >
> > Would those be good things to have as a whole package?
>
> I think the answer is we already do. It's called bash.

Just a stray thought...bash doesn't run very well on common Windows
installations.

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Simon Riggs 2008-04-30 15:46:14 Re: Patch to add a feature to pg_standby
Previous Message Simon Riggs 2008-04-30 14:43:54 Re: Patch to add a feature to pg_standby