Re: [HACKERS] Proposed patch - psql wraps at window width

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Bryce Nesbitt <bryce2(at)obviously(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Proposed patch - psql wraps at window width
Date: 2008-04-29 14:06:28
Message-ID: 20080429140628.GC5652@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian wrote:
> Bryce Nesbitt wrote:
> > Bruce Momjian wrote:
> > > I have updated the documentation for this patch. I consider it ready to
> > > apply. I think it is as close to a middle ground as we are going to
> > > get. Further adjustment will have to happen when we have more reports
> > > from the field.
> >
> > I heard a pretty compelling argument to make "wrapped" part of "aligned",
> > and thus I think the patch is ready to go only after adjusting the
> > user-facing syntax:

I think this is what makes the most sense of what I've seen so far.
Wrapped is a special case of aligned anyway (there's no "wrapped
unaligned" or "wrapped HTML" for example, nor would we want there to
be.)

> > Output format is aligned, no wrapping.
> >
> > \pset format aligned autowrap
> > Output format is aligned, with automatic wrapping to the window width for terminals.
> >
> > \pset format aligned 80
> > Output format is aligned, with a target width of 80 characters.

> Uh, well, we can do that, though looking at the psql code \pset only
> wants two arguments.

I think that could be fixed easily by having the syntax be something
like

\pset format aligned:80
\pset format aligned:autowrap

etc.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Dunstan 2008-04-29 14:14:29 Re: Protection from SQL injection
Previous Message Heikki Linnakangas 2008-04-29 13:52:30 Re: table format specification

Browse pgsql-patches by date

  From Date Subject
Next Message Zubkovsky, Sergey 2008-04-29 16:05:01 Re: [DOCS] pg_total_relation_size() and CHECKPOINT
Previous Message Hiroshi Saito 2008-04-29 14:02:31 Re: win32mak_patch