| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Zoltan Boszormenyi <zb(at)cybertec(dot)at> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Gregory Stark <stark(at)enterprisedb(dot)com>, pgsql-patches(at)postgresql(dot)org, Hans-Juergen Schoenig <hs(at)cybertec(dot)at>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: float4/float8/int64 passed by value with tsearch fixup |
| Date: | 2008-04-19 18:25:57 |
| Message-ID: | 20080419182557.GD6035@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Zoltan Boszormenyi wrote:
>>> So I think we really do need to offer that compile-time option.
>>> Failing to do so will be tantamount to desupporting v0 functions
>>> altogether, which I don't think we're prepared to do.
>>>
>>
>> I have asked the Cybertec guys for a patch. Since it's basically a copy
>> of the float8 change, it should be easy to do.
>
> Here's the patch (against current CVS) with the required change.
> Please review, it passed make check with both --enable and
> --disable-float4-byval.
Does it pass "make installcheck" in contrib? I'm worried about
btree_gist in particular. Perhaps the change I introduced in the
previous revision needs to be #ifdef'd out?
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zoltan Boszormenyi | 2008-04-19 18:56:02 | Re: float4/float8/int64 passed by value with tsearch fixup |
| Previous Message | Zoltan Boszormenyi | 2008-04-19 18:20:08 | Re: float4/float8/int64 passed by value with tsearch fixup |