Re: Lessons from commit fest

Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > What are we going to do about the duality of Windows vs. non-Windows?
> > Perhaps we could collect typedefs generated on the buildfarm.
>
> I think it's really not acceptable that pgindent misformats Windows-only
> code (or any other part of the code that Bruce doesn't care enough about
> to build on his system).
>
> This whole business of extracting the typedef names from object files
> sucks to begin with, and it will never not suck. If we have to have
> such a list, we need to find a more platform-independent procedure
> for getting it.

Based on that reaction I am not going to bother uploading my copy of the
typedefs.

"If it can't be perfect, don't bother doing it" seems to be the
approach, and because pgindent will never be perfect, I don't understand
why we bother even running it. Not finding all typedefs is only part of
the imperfect-ness of pgindent.

I think we use pgindent and an imperfect typedef list because it has
proven to be "good enough" to be useful.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +