Re: Idea for minor tstore optimization

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Neil Conway <neilc(at)samurai(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Idea for minor tstore optimization
Date: 2008-03-22 23:47:12
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Added to TODO:

* Avoid tuple some tuple copying in sort routines


Tom Lane wrote:
> Neil Conway <neilc(at)samurai(dot)com> writes:
> > I notice that several of the call sites of tuplestore_puttuple() start
> > with arrays of datums and nulls, call heap_form_tuple(), and then switch
> > into the tstore's context and call tuplestore_puttuple(), which
> > deep-copies the HeapTuple into the tstore. ISTM it would be faster and
> > simpler to provide a tuplestore_putvalues(), which just takes the datum
> > + nulls arrays and avoids the additional copy.
> Seems reasonable. Check whether tuplesort should offer the same, while
> you are at it.
> regards, tom lane
> ---------------------------(end of broadcast)---------------------------
> TIP 1: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly

Bruce Momjian <bruce(at)momjian(dot)us>

+ If your life is a hard drive, Christ can be your backup. +

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2008-03-23 00:05:16 Re: Reworking WAL locking
Previous Message Tom Lane 2008-03-22 22:32:51 Re: [HACKERS] Function structure in formatting.c