| From: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Suppress compiler warnings on mingw |
| Date: | 2008-03-14 05:34:49 |
| Message-ID: | 20080314141544.63DB.52131E4D@oss.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> ITAGAKI Takahiro wrote:
> > - Cast DWORD to unsigned integer explicitly.
> > DWORD is always 32bit integer on both 32bit and 64bit Windows.
>
> I think if that is so, you wouldn't need to add any casts. Instead you would
> only need to use the right format specifier.
DWORD is an alias for 'unsigned long' in 32bit Windows.
Do you know how it defined in 64bit Windows?
Postgres requires sizeof(long) = sizeof(void *), but sizeof(DWORD) is
always 4. I fear the formatter for long integer might be broken
in 64bit platform.
If we could expect C99 is always available, 'PRIu32' would be the best choice.
Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tucker, James | 2008-03-14 06:20:18 | minor init script fix |
| Previous Message | Peter Eisentraut | 2008-03-14 04:40:45 | Re: Suppress compiler warnings on mingw |