npgsql - Npgsql2: In new branch: Change behaviour of datareader to be

From: talliesin(at)pgfoundry(dot)org (User Talliesin)
To: pgsql-committers(at)postgresql(dot)org
Subject: npgsql - Npgsql2: In new branch: Change behaviour of datareader to be
Date: 2008-03-10 10:59:20
Message-ID: 20080310105920.B9EEF17AE651@pgfoundry.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
In new branch:

Change behaviour of datareader to be lazy-loaded as read rather than read in one batch.

Many changes to facilitate above change.

Only use UTF-8 encoding.

Use of typed collections instead of untyped, throughout.

Better recovery from thread-abort.

Better survival of connection damage. Connections retrieved from pool checked before use.

Add separate test cases for version2 protocol, so that version2 and version3 can be simultaneously tested.

Change test cases to close datareaders after use. The documentation for ExecuteReader says "While the IDataReader is in use, the associated IDbConnection is busy serving the IDataReader. While in this state, no other operations can be performed on the IDbConnection other than closing it. This is the case until the Close method of the DataReader is called. If the DataReader is created with CommandBehavior set to CloseConnection, closing the DataReader closes the connection automatically." Npgsql previously didn't enforce this rule, but has to with these changes. All test cases that broke this rule therefore had to be changed.

Tags:
----
RELEASE_2_0_ALPHA3

Modified Files:
--------------
Npgsql2/testsuite/noninteractive/NUnit20:
App.config (r1.2 -> r1.2.2.1)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/npgsql/Npgsql2/testsuite/noninteractive/NUnit20/App.config.diff?r1=1.2&r2=1.2.2.1)
BaseClassTests.cs (r1.1 -> r1.1.2.1)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/npgsql/Npgsql2/testsuite/noninteractive/NUnit20/BaseClassTests.cs.diff?r1=1.1&r2=1.1.2.1)
CommandTests.cs (r1.6 -> r1.6.2.1)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/npgsql/Npgsql2/testsuite/noninteractive/NUnit20/CommandTests.cs.diff?r1=1.6&r2=1.6.2.1)
ConnectionTests.cs (r1.4 -> r1.4.2.1)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/npgsql/Npgsql2/testsuite/noninteractive/NUnit20/ConnectionTests.cs.diff?r1=1.4&r2=1.4.2.1)
DataAdapterTests.cs (r1.1 -> r1.1.2.1)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/npgsql/Npgsql2/testsuite/noninteractive/NUnit20/DataAdapterTests.cs.diff?r1=1.1&r2=1.1.2.1)
DataReaderTests.cs (r1.1 -> r1.1.2.1)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/npgsql/Npgsql2/testsuite/noninteractive/NUnit20/DataReaderTests.cs.diff?r1=1.1&r2=1.1.2.1)
NpgsqlTests.csproj (r1.2 -> r1.2.2.1)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/npgsql/Npgsql2/testsuite/noninteractive/NUnit20/NpgsqlTests.csproj.diff?r1=1.2&r2=1.2.2.1)
Npgsql2/testsuite/noninteractive:
add_functions.sql (r1.2 -> r1.2.2.1)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/npgsql/Npgsql2/testsuite/noninteractive/add_functions.sql.diff?r1=1.2&r2=1.2.2.1)

Browse pgsql-committers by date

  From Date Subject
Next Message User Talliesin 2008-03-10 11:33:07 npgsql - Npgsql2: Fix reported bug #1010310
Previous Message User Talliesin 2008-03-10 10:58:58 npgsql - Npgsql2: In new branch: Change behaviour of datareader to be