Re: fix in --help output

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: fix in --help output
Date: 2008-03-02 20:30:16
Message-ID: 200803022030.m22KUGY09336@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Zdenek Kotala wrote:
> Ups. Patch attached

Tom has applied this patch to CVS HEAD and all relevant back-branches.

---------------------------------------------------------------------------

>
> Zdenek
>
> Zdenek Kotala napsal(a):
> > Tom Lane napsal(a):
> >> Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
> >>> I attached patch which replaces any "--..." occurrence with "-c..."
> >>> on command line.
> >>
> >> Please see whether forcibly using src/port/getopt.c fixes this,
> >> instead. A saner patch would probably add something like this
> >> to configure.in:
> >>
> >> if test "$PORTNAME" = "solaris"; then
> >> AC_LIBOBJ(getopt)
> >> AC_LIBOBJ(getopt_long)
> >> fi
> >
> > Yeah, this is the best solution. I attach a patch. Is possible to
> > backport it back to 8.3, 8.2?
> >
> > Just for completeness Solaris getopt function has a extension which
> > processes long option argument. This extension is called CLIP. This
> > implementation collides with unusual getopt usage for long option
> > processing in PostgreSQL.
> >
> > More info are there:
> > http://docs.sun.com/app/docs/doc/819-2243/getopt-3c?l=en&a=view
> > http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/lib/libc/port/gen/getopt.c
> >
> > http://docs.sun.com/app/docs/doc/819-2239/6n4hsf6e5?l=en&a=view
> >
> > By the way old solaris getopt version is similary with postgres
> > implementation. :-)
> >
> > http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/lib/libbc/libc/gen/common/getopt.c
> >
> >
> >
> > Thanks for help
> > Zdenek
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 2: Don't 'kill -9' the postmaster
>

>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: explain analyze is your friend

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message kenneth d'souza 2008-03-03 04:19:30 Reference by output in : \d <table_name>
Previous Message Bruce Momjian 2008-03-02 20:28:26 Re: --describe-config crashes