pgsql: Reducing the assumed alignment of struct varlena means that the

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Reducing the assumed alignment of struct varlena means that the
Date: 2008-02-29 17:47:41
Message-ID: 20080229174741.9991A754108@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Reducing the assumed alignment of struct varlena means that the compiler
is also licensed to put a local variable declared that way at an unaligned
address. Which will not work if the variable is then manipulated with
SET_VARSIZE or other macros that assume alignment. So the previous patch
is not an unalloyed good, but on balance I think it's still a win, since
we have very few places that do that sort of thing. Fix the one place in
tuptoaster.c that does it. Per buildfarm results from gypsy_moth
(I'm a bit surprised that only one machine showed a failure).

Modified Files:
--------------
pgsql/src/backend/access/heap:
tuptoaster.c (r1.82 -> r1.83)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/heap/tuptoaster.c?r1=1.82&r2=1.83)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2008-02-29 17:47:47 pgsql: Reducing the assumed alignment of struct varlena means that the
Previous Message User Andrewd 2008-02-29 17:41:42 pgbuildfarm - client-code: work around mingw's old version of File::Temp