| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Why we panic in pglz_decompress |
| Date: | 2008-02-29 14:09:33 |
| Message-ID: | 20080229140933.GC4673@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Zdenek Kotala wrote:
> I'm now looking into toast code and I found following code in
> pglz_decompress:
>
> 00704 if (destsize != source->rawsize)
> 00705 elog(destsize > source->rawsize ? FATAL : ERROR,
> 00706 "compressed data is corrupt");
>
>
> I'm surprise why we there panic?
Agreed, FATAL is too strong.
> My idea is to improve this piece of code and move error logging to
> callers (heap_tuple_untoast_attr() and heap_tuple_untoast_attr_slice())
> where we have a little bit more details (especially for external
> storage).
Why move it? Just adding errcontext in the callers should be enough.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Florian Weimer | 2008-02-29 14:10:22 | Re: Read-ahead and parallelism in redo recovery |
| Previous Message | Zdenek Kotala | 2008-02-29 13:55:36 | Why we panic in pglz_decompress |