pgsql: Remove unnecessary opening of other relation in

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove unnecessary opening of other relation in
Date: 2008-02-18 23:00:38
Message-ID: 20080218230039.004F9754108@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Remove unnecessary opening of other relation in RI_FKey_keyequal_upd_pk
and RI_FKey_keyequal_upd_fk, as well as no-longer-needed calls of
ri_BuildQueryKeyFull. Aside from saving a few cycles, this avoids needless
deadlock risks when an update is not changing the columns that participate
in an RI constraint. Per a gripe from Alexey Nalbat.

Back-patch to 8.3. Earlier releases did have a need to open the other
relation due to the way in which they retrieved information about the RI
constraint, so this problem unfortunately can't easily be improved pre-8.3.

Tom Lane and Stephan Szabo

Tags:
----
REL8_3_STABLE

Modified Files:
--------------
pgsql/src/backend/utils/adt:
ri_triggers.c (r1.103 -> r1.103.2.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/ri_triggers.c?r1=1.103&r2=1.103.2.1)

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2008-02-19 00:46:43 pgsql: Put fseeko check back in old location, in hopes of silencing
Previous Message Tom Lane 2008-02-18 23:00:32 pgsql: Remove unnecessary opening of other relation in