| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Tom Lane <tgl(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Sync our regex code with upstream changes since last time we did |
| Date: | 2008-02-15 18:45:55 |
| Message-ID: | 20080215184555.GA22581@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Andrew Dunstan wrote:
>
>
> Tom Lane wrote:
>> Note that I didn't make any effort to duplicate a lot of cosmetic changes
>> that they made to bring their copy into line with their own style
>> guidelines, such as adding braces around single-line IF bodies. Most of
>> those we either had done already (such as ANSI-fication of function headers)
>> or there is no point because pgindent would undo the change anyway.
>
> Not objecting, but IIRC we disabled the pgindent code that removes
> braces around single line (or rather statement) IF bodies several years
> ago.
Yeah, we did, because it was removing the braces around PG_TRY()
constructs.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Meskes | 2008-02-15 18:51:57 | pgsql: Updated expected result for regression test. |
| Previous Message | Tom Lane | 2008-02-15 17:19:47 | pgsql: Remove ancient restriction that LIMIT/OFFSET can't contain a |