Re: 8.3RC1 on windows missing descriptive Event handle names

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Stephen Denne <Stephen(dot)Denne(at)datamail(dot)co(dot)nz>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: 8.3RC1 on windows missing descriptive Event handle names
Date: 2008-01-31 09:25:03
Message-ID: 20080131092503.GC8942@svr2.hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 30, 2008 at 09:59:38PM +0100, Magnus Hagander wrote:
> Stephen Denne wrote:
> >I said...
> >>On Windows XP, using Process Explorer with the lower pane showing
> >>Handles, not all postgres.exe processes are including an "Event"
> >>type with a description of what the process is doing.
> >
> >I've had difficulty reproducing this, but I now suspect that it is
> >only happening when running both v8.2 and v8.3rc1 at once, and I
> >think it is the second started that is missing the process
> >descriptions.
>
> That makes sense, really - I think you nailed it. We create a global
> event, and for those that are "duplicates", it won't show up in the
> second process.
>
> I think the solution to this is to add the process id to the name of the
> event. So instead of:
> pgident: postgres: autovacuum launcher process
> We'd ahve
> pgident(12345): postgres: autovacuum launcher process
>
> Seems reasomable? I'll be able to write up and properly test a patch
> tomorrow.

I've applied a patch for this to HEAD and 8.2. It will be in the 8.3
release and in the next release of 8.2 when it's ready. It should be enough
that *one* of the two installations has the patch for the fix to work, so
8.3 release vs your current 8.2 should still work.

//Magnus

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2008-01-31 09:50:28 Re: Oops - BF:Mastodon just died
Previous Message Magnus Hagander 2008-01-31 08:42:56 Re: Oops - BF:Mastodon just died