Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Work around for perl 5.10 bug - fix due to perl hacker Simon

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Neil Conway <neilc(at)samurai(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Work around for perl 5.10 bug - fix due to perl hacker Simon
Date: 2008-01-29 16:42:28
Message-ID: 200801291642.m0TGgSh16494@momjian.us (view raw, whole thread or download thread mbox)
Thread:
Lists: pgsql-committers
Andrew Dunstan wrote:
> 
> I don't actually have a lot of information. Simon told me that, due to a 
> change in behaviour which he described as a bug, we need to enable the 
> caller opcode during the load of the strict module, and that we could 
> turn it off again once the module was imported. That's what I did (after 
> testing). It's a tiny and quite safe change. If you like I will add a 
> note to the code saying why it's there.

If 'require' is the typical way of doing this, and 'requier caller' is a
rare method, then the big problem is not the commit message but the lack
of description in the code as to why we are doing this.  It is unlikely
anyone will remember why we made this change, and what version of Perl
it is supposed to fix so we can revert it later perhaps.

---------------------------------------------------------------------------


> 
> cheers
> 
> andrew
> 
> Neil Conway wrote:
> > More information in the commit message would be good to see (for the
> > sake of the CVS history, if nothing else).
> >
> > -Neil
> >
> > On Tue, 2008-01-22 at 20:17 +0000, Andrew Dunstan wrote:
> >   
> >> Log Message:
> >> -----------
> >> Work around for perl 5.10 bug - fix due to perl hacker Simon Cozens.
> >>
> >> Modified Files:
> >> --------------
> >>     pgsql/src/pl/plperl:
> >>         plperl.c (r1.134 -> r1.135)
> >>         (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/pl/plperl/plperl.c?r1=1.134&r2=1.135)
> >>
> >> ---------------------------(end of broadcast)---------------------------
> >> TIP 6: explain analyze is your friend
> >>
> >>     
> >
> >
> >   
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 9: In versions below 8.0, the planner will ignore your desire to
>        choose an index scan if your joining column's datatypes do not
>        match

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://postgres.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

Responses

pgsql-committers by date

Next:From: Bruce MomjianDate: 2008-01-29 16:49:07
Subject: Re: pgsql: Document the fix for perl 5.10 with this comment: * The
Previous:From: Bruce MomjianDate: 2008-01-29 16:13:09
Subject: pgsql: Update wording: < * Add anonymous transactions > * Add

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group