Re: Revised patch for fixing archiver shutdown behavior

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgreSQL(dot)org, Simon Riggs <simon(at)2ndquadrant(dot)com>
Subject: Re: Revised patch for fixing archiver shutdown behavior
Date: 2008-01-10 15:28:03
Message-ID: 20080110152803.GG6465@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:

> There was discussion of having a lock file for the archiver, but
> it's still an open issue. I'm not sure how to solve the problem
> of stale lockfiles --- unlike the postmaster, the archiver can't
> assume that it's the only live process with the postgres userid.
> For example, after a system crash-and-restart, it's entirely
> likely that the PID formerly held by the archiver is now held
> by the bgwriter, making the lockfile (if any) look live.

Ah, right :-(

> Maybe we should go back to the plan of having the postmaster
> wait for the archiver to exit.

Yeah, that seems the safest to me -- the problem is that it complicates
the shutdown sequence a fair bit, because postmaster must act
differently depending on whether archiving is enabled or not: wait for
bgwriter exit if disabled, or for archiver exit otherwise.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Hiroshi Saito 2008-01-10 15:29:53 Re: reference problem of manifest.(win32.mak of libpq.dll)
Previous Message Magnus Hagander 2008-01-10 15:24:46 Re: reference problem of manifest.(win32.mak of libpq.dll)