Re: pgwin32_open returning EINVAL

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Jaime Casanova <systemguards(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Zeugswetter Andreas ADI SD <Andreas(dot)Zeugswetter(at)s-itsolutions(dot)at>, Gregory Stark <stark(at)enterprisedb(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Martijn van Oosterhout <kleptog(at)svana(dot)org>, Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgwin32_open returning EINVAL
Date: 2007-12-21 09:05:12
Message-ID: 20071221090512.GA3316@svr2.hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Dec 21, 2007 at 01:30:07AM -0500, Jaime Casanova wrote:
> On Dec 20, 2007 9:31 PM, Alvaro Herrera <alvherre(at)commandprompt(dot)com> wrote:
> > Jaime Casanova escribió:
> >
> > > it doesn't compile on current head on mingw 5.1 and msys 1.0.10; of
> > > course, it doesn't compile on 8.2 neither in order to Alvaro's contact
> > > to test it
> >
> > I think this patch should fix it. I think win32.mak needs to be
> > similarly patched.
> >
> >
>
> ok. it's solved now. i added the lines in the patch and pgsleep.o in
> (circa line 34 in src/interfaces/libpq)
>
> OBJS= fe-auth.o fe-connect.o fe-exec.o fe-misc.o fe-print.o fe-lobj.o \
> fe-protocol2.o fe-protocol3.o pqexpbuffer.o pqsignal.o fe-secure.o \
> md5.o ip.o wchar.o encnames.o noblock.o pgstrcasecmp.o thread.o \
> $(filter crypt.o getaddrinfo.o inet_aton.o open.o snprintf.o
> strerror.o strlcpy.o win32error.o pgsleep.o, $(LIBOBJS))

That's the wrong place - it should be added for win32 only.

Proper patch committed. Sorry 'bout that one. *grumble*

//Magnus

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2007-12-21 12:18:49 Re: pgwin32_open returning EINVAL
Previous Message Pavel Stehule 2007-12-21 08:18:18 Re: function body actors (was: viewing source code)