Re: pgindent issue with EXEC_BACKEND-only typedefs

Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > I don't know how to make it output the symbol names like it seems to do
> > for you.
>
> I dislike the object-file-based approach altogether, not least because
> it appears to depend on unportable aspects of someBSD's objdump.
>
> Surely there's some code out there that can find typedef names from the
> source files? Why does pgindent even need to be told this?

indent needs the typedef list. Maybe we can hack something based on
typedefs in the source code, instead of object files.

> > I am also wondering if current GNU indent is now better suited to the
> > task. Perhaps the bugs that it had on earlier versions have since been
> > fixed? I remember checking the source code size a couple of years ago
> > and it had grown by an order of magnitude or something like that.
>
> It might be interesting to try it again. It's been quite a few years
> since anyone tried it on the PG sources, AFAIK.

Right. I can't do it right now, but perhaps I can have a look at it
later.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support