Re: buildenv.pl/buildenv.bat

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: buildenv.pl/buildenv.bat
Date: 2007-12-05 15:47:30
Message-ID: 20071205154730.GE7641@svr2.hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 04, 2007 at 09:31:30AM -0500, Andrew Dunstan wrote:
>
>
> Magnus Hagander wrote:
> >>My recollection is that I changed the minimum amount necessary, because
> >>I was expecting us to go into beta at anmy moment (silly me). That might
> >>be why we still have both. There was an expectation that some cleanup
> >>might be required during 8.4 development. I know I left other .bat files
> >>as wrappers for the perl scripts, but that's obviously not appropriate
> >>here. I'll see if I can adjust builddoc.bat so we can get rid of
> >>buildenv.bat.
> >>
> >>As for documentation, you're probably right, I could easily have missed
> >>it. I'll look into it.
> >>
> >
> >Great. Let me know if you need me to poke at anything.
> >
> >
> >
>
> OK, I'm thinking that the best way might be to do away with buildenv.bat
> altogether and replace the remaining references to it in .bat files with
> something like this fragment:
>
> if not exist src\tools\msvc\buildenv.pl goto nobuildenv
> perl -e "require 'src/tools/msvc/buildenv.pl'; while(($k,$v) = each
> %ENV) { print qq[\(at)SET $k=$v\n]; }" > tmp.bat
> call tmp.bat
> del tmp.bat
> :nobuildenv
>
> and adjust the docs accordingly.
>
> Thoughts?

Urgh.

I thought you specifically changed the earlier scripts to *avoid* having
them create a temporary file and then execute it. Which I agreed with :-)

I think I'd prefer we just get rid of the .bat's completely then.

I wonder if we are daring enough to do it so late in the cycle, though..

//Magnus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Walter Cruz 2007-12-05 16:01:40 Re: weird - invalid string enlargement request size
Previous Message Greg Sabino Mullane 2007-12-05 14:26:17 Re: Better default_statistics_target