From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Still a NOTICE in dict_thesaurus.c |
Date: | 2007-11-27 23:13:35 |
Message-ID: | 200711272313.lARNDZt05046@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Thanks, working on this now. Because the stop words can be any stop
word I didn't imagine it could be in the subsitution. What stop word
will it use? Anyway, coding it now to match the left-hand-side.
---------------------------------------------------------------------------
Tom Lane wrote:
> Wasn't this patch
> http://archives.postgresql.org/pgsql-committers/2007-11/msg00170.php
> supposed to fix things so that we wouldn't be throwing NOTICEs out of
> tsearch dictionary init functions? It seems to have gotten only
> one of the two elog(NOTICE) calls in there. The other one is for a
> stopword in the replacement phrase. Is there any objection to making
> that an ERROR too?
>
> Also, several of the elog's in this file ought to be ereport's since
> they are user-caused error conditions. I think we are nominally past
> string freeze, but does anyone have an objection to changing them to
> ereport's? If they don't get translated, the worst that will happen
> is that they come out in English, which is what's happening now.
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faq
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2007-11-27 23:15:28 | Re: Still a NOTICE in dict_thesaurus.c |
Previous Message | Joshua D. Drake | 2007-11-27 23:08:40 | Re: Quality and Performance |