| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us>, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Still a NOTICE in dict_thesaurus.c |
| Date: | 2007-11-27 22:26:36 |
| Message-ID: | 12525.1196202396@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Wasn't this patch
http://archives.postgresql.org/pgsql-committers/2007-11/msg00170.php
supposed to fix things so that we wouldn't be throwing NOTICEs out of
tsearch dictionary init functions? It seems to have gotten only
one of the two elog(NOTICE) calls in there. The other one is for a
stopword in the replacement phrase. Is there any objection to making
that an ERROR too?
Also, several of the elog's in this file ought to be ereport's since
they are user-caused error conditions. I think we are nominally past
string freeze, but does anyone have an objection to changing them to
ereport's? If they don't get translated, the worst that will happen
is that they come out in English, which is what's happening now.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2007-11-27 22:39:49 | Re: PG 7.3 is five years old today |
| Previous Message | Tom Lane | 2007-11-27 22:17:51 | Poorly named support routines for GIN tsearch index opclasses |